Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Limit to a single Haskell job on macOS #564

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    CI: Limit to a single Haskell job on macOS
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Comment on lines 19 to 20
# Using include, to make sure only be one macOS job, even if the matrix gets expanded later on.
# We want a single job, because macOS runners are scarce.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Using include, to make sure only be one macOS job, even if the matrix gets expanded later on.
# We want a single job, because macOS runners are scarce.
# Using include, to make sure there will be only one macOS job, even if the matrix gets expanded later on.
# We want a single job, because macOS runners are scarce.

@newhoggy newhoggy force-pushed the newhoggy/limit-macOS-jobs branch from 40cd7eb to b5d72bf Compare January 12, 2024 10:40
@newhoggy newhoggy added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 3793d9c Jan 12, 2024
16 checks passed
@newhoggy newhoggy deleted the newhoggy/limit-macOS-jobs branch January 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants